Repository navigation
fix(plot): default to environment-managed Matplotlib display - #84
huxiaoyi-ovo wants to merge 6 commits into
Conversation
Align plot() and highlight_path() with the RVC block contract without changing explicit True/False handling. Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 9 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
|
Thank you for your interest in pgraph-python, and for this contribution. This brings I'm happy to take this as a deliberate behaviour change. Before merging, could you:
Thanks again, and let me know if you'd rather I made any of these changes myself. |
|
Hi Peter, I've pushed the requested updates. Both plotting methods now have The branch is up to date with Could you approve the upstream CI run when convenient? Thanks for the detailed review! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 4 4
Lines 1649 1649
=======================================
Hits 1618 1618
Misses 31 31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Fixes #79.
Updated
Graph.plot()andGraph.highlight_path()to default toblock=None, allowing Matplotlib display to be managed by the calling environment.Previously, both methods defaulted to
block=Falseand calledplt.show(block=False)even when no display behaviour was specified. Explicitblock=Falseandblock=Trueretain their existing behaviour.Documentation
versionchanged:: 1.1notes to both methods.Unreleasedin the CHANGELOG.Scripts that previously relied on
g.plot()opening a window can useplt.show()orblock=False.Tests
Added regression coverage for all three
blockmodes, including default plotting followed byhighlight_path(block=False)and plotting with caller-provided axes.Fork CI passed: https://github.com/huxiaoyi-ovo/pgraph-python/actions/runs/41379496007
AI assistance: ChatGPT (GPT-6) assisted with code review, documentation, and regression tests.